Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC deadline and clock skew on different machines #366

Closed
ditsing opened this issue May 26, 2022 · 2 comments · Fixed by #367
Closed

RPC deadline and clock skew on different machines #366

ditsing opened this issue May 26, 2022 · 2 comments · Fixed by #367
Assignees

Comments

@ditsing
Copy link

ditsing commented May 26, 2022

I have a development machine machine and a Raspberry pi that happens to have its system clock out of sync. All my RPCs from Pi to my machine would fail with DeadlineExceeded, because Pi sets the deadline at 2021.

Does it make sense to use relative time (10 seconds) instead of absolute system time to represent RPC deadline? Given typical clock skew between machines could be O(seconds), using absolute time seems quite inaccurate.

@tikue tikue self-assigned this May 26, 2022
@tikue
Copy link
Collaborator

tikue commented May 26, 2022

Hey, thanks for the great question! That definitely sounds like an annoying problem! I think you're right that a relative deadline should be sent over the wire — it can then be converted back to an absolute deadline on the other end, so that deadline propagation between multiple RPC hops works correctly.

@tikue
Copy link
Collaborator

tikue commented May 26, 2022

@ditsing I'd love your feedback on #367 before I merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants