Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tikv to persist #73

Merged
merged 1 commit into from
May 12, 2020
Merged

add tikv to persist #73

merged 1 commit into from
May 12, 2020

Conversation

masihtehrani
Copy link
Contributor

fix #69

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid start.

Is there anything missing other than implementing Initialize() to load the data?

@masihtehrani
Copy link
Contributor Author

masihtehrani commented May 8, 2020

Looks like a solid start.

Is there anything missing other than implementing Initialize() to load the data?

thank you @tstromberg
it's not complete
I wrote have one question in #69

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@masihtehrani masihtehrani marked this pull request as ready for review May 11, 2020 03:36
@masihtehrani
Copy link
Contributor Author

@googlebot I signed it!

@masihtehrani masihtehrani changed the title [WIP] add tikv to persist add tikv to persist May 11, 2020
@tstromberg
Copy link
Collaborator

Thank you!

@tstromberg tstromberg merged commit 2b5527b into google:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TiKV support for cache persistence
3 participants