Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Replace usages of dart:math geometry types with custom types #316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

parlough
Copy link
Collaborator

@parlough parlough commented Feb 14, 2025

This is a breaking change and shouldn't be included until the next major release.

These types were built for dart:html, contain unrelated functionality, and require this library to always add an int generic. To aid the deprecation of these types in dart:math, migrate this package to custom types. These types, particularly the addition of a new Size type can more semantically match their purpose in the package, and be a bit simpler to use, no longer having a type parameter.

Contributes to dart-lang/sdk#54852

@devoncarew
Copy link
Collaborator

I don't know that I have enough context on the 'why' to evaluate this PR. Perhaps we should resolve dart-lang/sdk#54852 first? cc @kevmoo for thoughts

@parlough
Copy link
Collaborator Author

I don't know that I have enough context on the 'why' to evaluate this PR. Perhaps we should resolve dart-lang/sdk#54852 first?

That issue is the why for this. This package seems to be the only dependency of Flutter that uses these types, being a blocking stop in deprecating the types.

Happy to continue the discussion in that issue first though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants