Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryFromBytes::is_bit_valid should promise not to mutate its referent #1831

Open
joshlf opened this issue Oct 6, 2024 · 3 comments
Open

TryFromBytes::is_bit_valid should promise not to mutate its referent #1831

joshlf opened this issue Oct 6, 2024 · 3 comments

Comments

@joshlf
Copy link
Member

joshlf commented Oct 6, 2024

No description provided.

@joshlf joshlf mentioned this issue Oct 6, 2024
Closed
26 tasks
@jswrenn
Copy link
Collaborator

jswrenn commented Oct 6, 2024

Why?

@joshlf
Copy link
Member Author

joshlf commented Oct 6, 2024

Presumably callers expect that &mut [u8] -> &mut T (e.g. TryFromBytes::try_mut_from_bytes) is just a pointer cast and will not mutate the bytes.

@joshlf joshlf mentioned this issue Oct 5, 2024
Open
@joshlf
Copy link
Member Author

joshlf commented Nov 18, 2024

Note: This affects #1330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshlf @jswrenn