feat: add startAsyncCall support #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
reviewed
Aug 23, 2022
bshaffer
reviewed
Aug 26, 2022
Co-authored-by: Brent Shaffer <[email protected]>
dwsupplee
approved these changes
Sep 7, 2022
dwsupplee
approved these changes
Sep 7, 2022
bshaffer
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
startAsyncCalltoGapicClientTraitthat initiates an API call viastartApiCall, but directly returns the resultingPromisefor the user to handle. Does not support Streaming RPCs today. To support async initialization of a PagedResponse, I added agetPagedListResponseAsyncvariant with all of the logic needed today, which is then called from the synchronous variant and waited upon.Also moves all of the "call config" validation into a helper used by both
startApiCallandstartAsyncCall.