Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-popups: * true rule blocks opening of a clicked url #1066

Closed
harshanvn opened this issue Dec 14, 2015 · 2 comments
Closed

no-popups: * true rule blocks opening of a clicked url #1066

harshanvn opened this issue Dec 14, 2015 · 2 comments

Comments

@harshanvn
Copy link

Background Info: When you have popups blocked globally no-popups: * true, clicking a link on a page some times is blocked.

STR - (tested in firefox v42 only)

  1. Add no-popups: * true rule.

  2. Try clicking a link present in this post.

  3. We will see the new tab opening blocked with the logger reporting below -

    no-popups: * true -- popup about:blank

Note: Looks like this is fixed in v1.4.1 beta @945a8a9. Just opened to better track the issue and link the commit and close the issue..
@harshanvn harshanvn changed the title no-popups: * true rule blocks openining of a clicked url <code>no-popups: * true</code> rule blocks openining of a clicked url Dec 14, 2015
@harshanvn harshanvn changed the title <code>no-popups: * true</code> rule blocks openining of a clicked url "no-popups: * true" rule blocks openining of a clicked url Dec 14, 2015
@harshanvn harshanvn changed the title "no-popups: * true" rule blocks openining of a clicked url "no-popups: * true" rule blocks opening of a clicked url Dec 14, 2015
@gorhill
Copy link
Owner

gorhill commented Dec 14, 2015

Fixed with 945a8a9.

@gorhill gorhill closed this as completed Dec 14, 2015
@harshanvn
Copy link
Author

Thanks!

@gorhill gorhill changed the title "no-popups: * true" rule blocks opening of a clicked url no-popups: * true rule blocks opening of a clicked url Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @harshanvn