Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing new all-contributors app #163

Closed
gr2m opened this issue Dec 30, 2020 · 36 comments
Closed

testing new all-contributors app #163

gr2m opened this issue Dec 30, 2020 · 36 comments

Comments

@gr2m
Copy link
Owner

gr2m commented Dec 30, 2020

No description provided.

@cloudflare-worker-example
Copy link

Hello there from Cloudflare Workers

@gr2m
Copy link
Owner Author

gr2m commented Dec 30, 2020

@all-contributors please add @gr2m-test for infrastructure, tests and code

@all-contributors-preview
Copy link

@gr2m

I've put up a pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Dec 30, 2020

@all-contributors please add @gr2m-test for infrastructure, tests and code

@all-contributors-preview
Copy link

@gr2m

I've updated the pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 1, 2021

@all-contributors please add @gr2m-test for code

@all-contributors-preview
Copy link

@gr2m

I've updated the pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 1, 2021

@all-contributors please add @gr2m-test for tests

@all-contributors-preview
Copy link

@gr2m

I've updated the pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 1, 2021

@all-contributors please add @gr2m-test for infrastructure

@all-contributors-preview
Copy link

@gr2m

I've updated the pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 1, 2021

@all-contributors please add @gr2m-test for infrastructure

@allcontributors
Copy link
Contributor

@gr2m

I've put up a pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 4, 2021

@all-contributors please add @gr2m-test for tests

@allcontributors
Copy link
Contributor

@gr2m

I've put up a pull request to add @gr2m-test! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 4, 2021

@all-contributors please add @gr2m for tests

@allcontributors
Copy link
Contributor

@gr2m

I've put up a pull request to add @gr2m! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 14, 2021

@all-contributors please add @Berkmann18 for mentoring

@all-contributors-preview
Copy link

@gr2m

I've put up a pull request to add @Berkmann18! 🎉

@Berkmann18
Copy link

@all-contributors please add @Berkmann18 for code

@all-contributors-preview
Copy link

@Berkmann18

We had trouble processing your request. Please try again later.

@gr2m
Copy link
Owner Author

gr2m commented Jan 18, 2021

the error was

TypeError: Cannot read property 'files' of undefined
    at Config.get (/var/task/lib/modules/config.js:73:32)
    at convertMessage (/var/task/lib/modules/convert-message.js:5:49)
    at Repository.updateFile (/var/task/lib/modules/repository.js:128:16)
    at Repository.createOrUpdateFile (/var/task/lib/modules/repository.js:153:18)
    at /var/task/lib/modules/repository.js:166:27
    at Array.map (<anonymous>)
    at Repository.createOrUpdateFiles (/var/task/lib/modules/repository.js:164:69)
    at Repository.createPullRequestFromFiles (/var/task/lib/modules/repository.js:236:16)
    at addContributor (/var/task/lib/add-contributor.js:51:24)
    at async processIssueComment (/var/task/lib/process-issue-comment.js:61:33)

@gr2m
Copy link
Owner Author

gr2m commented Jan 18, 2021

It should have been reported to sentry, the sentry event ID is 22c294492d3b4aaca6c44d1a8748cdcd. But it's not showing up in the sentry.io app yet

@Berkmann18
Copy link

It may be taking time in showing up.
As for the error, I'll see if I can find a better solution whenever I'm free.

@gr2m
Copy link
Owner Author

gr2m commented Jan 18, 2021

I think it's the same error that you see in the tests here? https://github.com/all-contributors/app/pull/343/checks?check_run_id=1723922388#step:5:13

@Berkmann18
Copy link

Berkmann18 commented Jan 19, 2021

That's true and it indeed seems that it only fails in the PR.
Edit: It should hopefully work now.

@Berkmann18
Copy link

@all-contributors please add @Berkmann18 for code

@all-contributors-preview
Copy link

@Berkmann18

I've updated the pull request to add @Berkmann18! 🎉

@Berkmann18
Copy link

Note (to self): check if the PR title is consistent with the commits when (the convention isn't Angular) if so the PR would be good to go.

@Berkmann18
Copy link

@all-contributors please add @gr2m for infra

@all-contributors-preview
Copy link

@Berkmann18

I've updated the pull request to add @gr2m! 🎉

@Berkmann18
Copy link

It seems like we need to have tests that read a mocked/dummy .all-contributorsrc and test when some of the values there differ. I'm not sure why there's an inconsistency in the PR above.

@gr2m
Copy link
Owner Author

gr2m commented Jan 19, 2021

looks like #167 was created by the @allcontributors app, not by @all-contributors-preview. Sorry, my fault. I installed the @allcontributors app all of my @gr2m repositories and forgot that I tested the preview here in this repo.

How about we create a new organization @all-contributors-sandbox for dedicated testing?

@all-contributors-preview
Copy link

@gr2m

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@all-contributors-preview
Copy link

@all-contributors-preview[bot]

I've put up a pull request to add @Someone! 🎉

@gr2m
Copy link
Owner Author

gr2m commented Jan 19, 2021

oh oh :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants