Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeGraph: Allow specifying an icon for node in node graph #57443

Closed
aocenas opened this issue Oct 21, 2022 · 2 comments
Closed

NodeGraph: Allow specifying an icon for node in node graph #57443

aocenas opened this issue Oct 21, 2022 · 2 comments

Comments

@aocenas
Copy link
Member

aocenas commented Oct 21, 2022

Currently our service map shows just a simple circular nodes with some stats inside:

node-graph-8-0

This does not make it easy to visually recognize type of a node, like what kind of service it is like a database, message queue, app etc. For example some way other systems differentiate nodes:
service_map_wide
2-traceMap

There is a bit of research required about the actual implementation. We can just allow defining a name of an icon in a dataframe column from a predefined set of icons included in Grafana. Not sure if it's easily possible to add new icons from a data source plugin but I have a feeling that would be somewhat complex at this point.

It also probably a good guess that data source itself is the best place to know what kind of icon each node should have so data sources will have to implement some sort of matching based on data they have available to the set of predefined icons.

There is also a possibility to add a visualization configuration to match node name pattern to an icon manually tweaking or adding icons where they are not available from the data source, but would consider this a stretch goal and probably a later separate feature request.

@adrapereira
Copy link
Contributor

Related: #54843

@aocenas
Copy link
Member Author

aocenas commented Mar 27, 2023

Done in #60989

@aocenas aocenas closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants