feat: standalone monaco API #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heads up @Nishchit14 - changing this API so it's easier to use! thanks @rebornix for the advice on this. works much better this way. no more typescript mess @cshaver ! |
acao
force-pushed
the
feature/rewrite-improve-monaco-api
branch
2 times, most recently
from
dd90464 to
084940b
Compare
- replace `monaco.languages.graphql` with an `api` export object - combine api and defaults into one interface - get rid of `.d.ts` typings and module extension which caused issues for normal .ts typings - update documentation to reflect API changes
acao
force-pushed
the
feature/rewrite-improve-monaco-api
branch
from
084940b to
068a9bf
Compare
acao
force-pushed
the
feature/rewrite-improve-monaco-api
branch
from
1be45f2 to
7e307f4
Compare
acao
changed the title
acao
force-pushed
the
feature/rewrite-improve-monaco-api
branch
3 times, most recently
from
d6d8b22 to
a2c3b74
Compare
acao
force-pushed
the
feature/rewrite-improve-monaco-api
branch
from
a2c3b74 to
d2850d9
Compare
thenamankumar
pushed a commit
to thenamankumar/graphiql
that referenced
this pull request
Aug 30, 2020
- replace monaco.languages.graphql with an api export object - combine api and defaults into one interface - get rid of .d.ts typings and module extension which caused issues for normal .ts typings - update documentation to reflect API changes - add setSchema() - use `createData.languageConfig` for LSP config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monaco.languages.graphqlwith anapiexport object.d.tstypings and module extension which caused issues for normal .ts typingssetSchema()