This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Get the global stats periodically #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global stats, user count and weekly dollar exchange, were being gathered on every single request, even requests for static assets. This commit changes the action to only look in the database during homepage cache updates and carry the data in memory so it is available to the application.
| request.context['gnactive'] = gnactive | ||
| request.context['gtransfer_volume'] = gtransfer_volume | ||
|
|
||
| website.hooks.inbound_early += [add_stuff] |
There was a problem hiding this comment.
How about we rename the add_stuff method to something like set_up_session_context?
| @@ -340,6 +341,15 @@ def get_participant(request, restrict=True): | |||
| return participant | |||
|
|
|||
|
|
|||
| def update_global_stats(website): | |||
| stats = gittip.db.one( "SELECT nactive, transfer_volume FROM paydays " | |||
There was a problem hiding this comment.
While we're at it, we may as well use website.db here instead of gittip.db. Eventually we want to root out the gittip.db global (#1528).
chadwhitacre
added a commit
that referenced
this pull request
Oct 25, 2013
Get the global stats periodically
|
!m @bruceadams |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global stats, user count and weekly dollar exchange, were being gathered on every single request, even requests for static assets. This commit changes the action to only look in the database during homepage cache updates and carry the data in memory so it is available to the application.