This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
use TwitterAccount's get_url instead of custom html_url #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynekwinkler
added a commit
that referenced
this pull request
Feb 8, 2014
use TwitterAccount's get_url instead of custom html_url
| @@ -12,7 +12,7 @@ | |||
| No Twitter account connected. | |||
| {% endif %} | |||
| {% else %} | |||
| <a rel="me" href="{{ twitter_account.user_info.get('html_url', '')|e }}" | |||
| <a rel="me" href="{{ twitter_account.get_url() }}" | |||
There was a problem hiding this comment.
We lost the escaping here. Was that intentional? Do we know that get_url() returns a safe value?
There was a problem hiding this comment.
I removed the escaping because get_url is this:
def get_url(self):
return "https://twitter.com/" + self.user_info['screen_name']and I'm pretty sure we can expect Twitter to provide an HTML-safe username, since they only allow alphanumeric characters (+ underscore).
My other motivation was that there are plenty of places where we don't currently escape this data. If this approach is vulnerable, then we were already vulnerable.
|
Good catch, @seanlinsley. Sorry about that! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1997 by using what we have instead of relying on a derivative value from the database (that happened to be blown away by #1989)