Remove/Replace Balanced from Credit card page

[kaguillera]

Failed test for the removal of Balanced from the Credit-card page

[chadwhitacre]

Partially addresses Closes #3514.

[kaguillera]

Please review. @whit537, @rohitpaulk

[rohitpaulk]

Added few commits, rebased on master. cc: @kaguillera

[kaguillera]

Removed Balanced TOS and Privacy Policy from the spt and md files since we are no longer using them. Replaced the information with Braintree's not sure if what I placed is legally appropriate since not all of the functions performed by Balanced are being done by Braintree.
Please review @whit537
This should take care of #3513

[chadwhitacre]

Rebased on master.

[chadwhitacre]

I would like to see this PR not affect our test fixtures. What's requiring network access here?

Secondly, I'm not sure the failing test where we check that certain text is no longer on the page is the best idea, because there's an infinity of text we could check for the absence of. I think it makes more sense to test for the presence of Braintree.

The legalese needs to be proofread ...

[chadwhitacre]

@kzisme in #3769:

When reviewing a users routes page

https://gratipay.com/~kzisme/routes/

There is still an image showing that payments are

Is there a preferred image that could replace the existing or would it be okay to keep it around?

[chadwhitacre]

Is there a preferred image that could replace the existing or would it be okay to keep it around?

@kzisme To answer your question we definitely want to get Balanced off the site since we're not processing with them anymore (last thing is #3539). There's some issues with this PR, I'm planning to get to it at some point post-Pivot, but if anyone else wants to review/work on it before then, go for it! :-)

[kzisme]

No worries I was just clicking around on my own account and noticed that and figured it would/could be documented. 😄

[chadwhitacre]

@mattbk Would you be willing and able to pick up with this one? It's on the Balanced Shutdown milestone, which is due soon.

[mattbk]

I think so, I assume I have to learn how to rebase?

[chadwhitacre]

@mattbk And resolve conflicts. If that's too much trouble you could close this and start over.

[mattbk]

Okay, I'll look into it this week.

[chadwhitacre]

Awesome, thanks. :)

[mattbk]

I rebased on master (I think). The only conflict was on test_pages.py, so I did not merge that file. I'm not really sure what the tests do, so I guess I'm looking into that.

[mattbk]

For me to make progress on this I'm going to have to diff test_pages.py and see how things are supposed to work.

[mattbk]

Test failed because I didn't indent right.

[chadwhitacre]

Rebased on master. Original HEAD was edbbd86.

[chadwhitacre]

Secondly, I'm not sure the failing test where we check that certain text is no longer on the page is the best idea, because there's an infinity of text we could check for the absence of.

[chadwhitacre]

But I'm reluctant to remove that test now that @mattbk has finally gotten it working. :-)

!m @mattbk

[chadwhitacre]

Gonna proofread ...

[chadwhitacre]

But I'm reluctant to remove that test now that @mattbk has finally gotten it working. :-)

Sorry, @mattbk did observe #3565 (comment), but the name of the test threw me off. ;-)

[chadwhitacre]

8252a5b closes #3513.

[chadwhitacre]

I think we're ready here. Anything else @nathany @mattbk @kaguillera?