revise the Team application

[chadwhitacre]

Closes #3677.

[chadwhitacre]

Rebased on master.

[chadwhitacre]

• Add a couple more checkboxes for public review and payroll agreement.
• Add validation for URLs.
• Test with empty URLs (for pre-existing Teams)
• i18n

[chadwhitacre]

Right direction, @mattbk et al.?

[mattbk]

I like it.

[chadwhitacre]

I propose that we land this without "How to Review Team Applications," and then once we write that we link "publicly reviewed" there instead of to the applications issue tracker.

[chadwhitacre]

Empty URLs are fine, we just don't show those links:

[chadwhitacre]

Here's what it looks like with the links filled out:

[chadwhitacre]

I keep waffling about the "Issues" term. Waddya think?

• Issues
• TODO
• Tracker
• Tickets
• Work Available

[chadwhitacre]

I like something more general, like TODO or Work Available, because it leaves open the specific tooling in use.

[mattbk]

"Work Available" is clear.

[chadwhitacre]

"To-do" is a pretty common term (I don't think it's limited to geeks, is it? TODO would be, but To-do I think is okay). And it's what I used for the field name, todo_url. :-)

[mattbk]

I would avoid TODO because it looks like an acronym to non-coders.

[chadwhitacre]

@mattbk How about if it's spelled "To-do" instead (see my previous comment)?

[chadwhitacre]

Another thought: Teams are in between. On the one hand a Team page should appeal to ~users who want to give payments to the Team, and on the other to ~users who want to do work and take payroll. Out of scope for this PR but something to keep in mind when we're able to circle back around to #3248.

[chadwhitacre]

Okay! I think this PR is ready for final review. Deployment notes:

• find URLs to backfill for existing teams

[chadwhitacre]

@mattbk et al. Wanna help me fill out this CSV? :)

/me starts at the bottom ...

[mattbk]

Can you give me access?

[chadwhitacre]

@mattbk I would expect that you can simply click and start editing. No?

[chadwhitacre]

I looked for a "sharing" setting and didn't see it ...

[mattbk]

I get "Unauthorized [403]" and I am logged in with github.

[chadwhitacre]

Interesting! Okay, one sec ...

[chadwhitacre]

Try this? https://demo.sandstorm.io/shared/R2Q574YpMAGntRLfAc9GH_S0nhClBu45Dx_Pmug4-sn

[chadwhitacre]

"Demo expires in in 49 minutes." Hurry! 💃

[mattbk]

I charged through a bunch of them, but have to run now.

[chadwhitacre]

!m @mattbk

[chadwhitacre]

Moved to http://pad.totalism.org/p/backfill-gratipay-urls.

[chadwhitacre]

Hmmm ... I think we should keep the revenue_model, getting_involved, and getting_paid columns around, but only make them visible to the Team owner on the edit page (#3545), in case they want to copy/paste some of that text over to the main textarea.

[chadwhitacre]

Done! https://gist.github.com/whit537/acc4bf816f18eb9e9088

[chadwhitacre]

I manually updated eight homepages that didn't have a protocol prefixed (one is a mailto:!).

[chadwhitacre]

I added a little script to that gist, for generating SQL updates from the CSV.

[chadwhitacre]

Alright. Going for it ...