Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaeyeonRoyce
force-pushed
the
13-feat-구독한-구글폼-응답-최신화-및-알림-발송
branch
from
8cab2c3 to
d48b627
Compare
TaeyeonRoyce
force-pushed
the
13-feat-구독한-구글폼-응답-최신화-및-알림-발송
branch
from
d48b627 to
54a9551
Compare
davidolleh
reviewed
Feb 27, 2025
| @@ -2,5 +2,9 @@ spring: | |||
| application: | |||
| name: greedy-bot | |||
|
|
|||
| main: | |||
| web-application-type: none | |||
There was a problem hiding this comment.
이것은 웹 서버 없이 spring을 실행 하는 조건 같은데
- 해당 그림에서 tomcat 관련 기능들을 들고 오지 않는 것일까요?
- 저희 디스코드 앱은 controller없이 작동하기에 추가한 것일까요?
There was a problem hiding this comment.
네, 처음에도 web 의존서 없이 사용하다가 restClient를 위해 추가했었는데요.
DiscordBot은 소켓으로 연결해서 사용 되지 않는내장 톰캣을 띄우는게 비효율적이라 생각했습니다!
|
수고하셨습니다 👍 |
davidolleh
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고사항
코드 lint 하느라 변경된 파일들이 조금 있어요.
로직 변경 커밋 실제 로직은 위 커밋들입니다.
관련 이슈
PR 체크리스트