Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Timeout test #1258

Closed
johanbrandhorst opened this issue Apr 30, 2020 · 3 comments
Closed

Flaky Timeout test #1258

johanbrandhorst opened this issue Apr 30, 2020 · 3 comments

Comments

@johanbrandhorst
Copy link
Collaborator

As illustrated by https://app.circleci.com/pipelines/github/grpc-ecosystem/grpc-gateway/281/workflows/57fdb518-e3ee-4f16-9a55-0f417732ca80/jobs/7654/steps, one of the integration tests is sometimes failing with the wrong error. We should figure out why this is happening and fix it.

This should be a good issue to get introduced to the codebase. The test is here: https://github.com/grpc-ecosystem/grpc-gateway/blob/master/examples/internal/integration/integration_test.go#L1302

@Abhi-khandelwal
Copy link

Any idea why I am getting this error?

WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated. A future release of golang/protobuf will delete this package, which has long been excluded from the compatibility promise.

@Abhi-khandelwal
Copy link

I think we should use the "google.golang.org/protobuf/compiler/protogen" package as adviced

https://github.com/golang/protobuf/blob/d04d7b157bb510b1e0c10132224b616ac0e26b17/protoc-gen-go/generator/generator.go#L10-L11

@johanbrandhorst
Copy link
Collaborator Author

Hi Abhi, indeed, we've replaced the use of that package in our v2 branch, which we're close to making a first release of soon.

On another note, I think this was fixed by changing the ports used for some of the tests, so I'm going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants