Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Snyk sbt workflow #340

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

rhystmills
Copy link
Contributor

@rhystmills rhystmills commented Feb 5, 2025

What does this change?

The Snyk sbt workflow is deprecated, and we have removed it in other repos.

I also don't think Pinboard has any Scala in it, or sbt dependencies (it's all TypeScript), so I'm unsure what value the workflow would provide if it weren't deprecated.

As an organisation are moving from Snyk to Dependabot for vulnerability management.

(Please let me know if I'm missing something!)

@rhystmills rhystmills requested review from twrichards and a team as code owners February 5, 2025 09:39
Copy link

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Agreed that we don't need to replace this as the repository doesn't have any scala or kotlin code (the only two cases DevX have mentioned where github's inbuilt dependency tracking doesn't work for us).

@rhystmills rhystmills merged commit 0fd5d49 into main Feb 5, 2025
3 checks passed
@rhystmills rhystmills deleted the rm/remove-snyk-workflow branch February 5, 2025 09:44
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @rhystmills 3 minutes and 13 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants