feat: support typestripping extension #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
typestripping
branch
from
4eb82b3 to
dba52c3
Compare
guybedford
force-pushed
the
typestripping
branch
from
dba52c3 to
cbd5404
Compare
guybedford
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the old SystemJS workflow of supporting TypeScript in-browser, making for a nice es-module-shims modern JS dev experience.
This implements a new
es-module-shims-typescript.jsextension that is loaded dynamically when TypeScript syntax is imported that inlines the Amaro project to support the same type stripping from Node.js.With this change, files served with a TypeScript MIME type or without a valid module MIME type but with a
.tsor.tsmextension automatically get type stripping applied. Because TS files break browsers it automatically engages polyfill mode but also works in shim mode too.It ends up being around a 2MB loader file, and we can probably get this down with future optimizations.