Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend for magic link additions #355

Closed
nickbeaird opened this issue Oct 22, 2020 · 6 comments · Fixed by #361
Closed

Refactor backend for magic link additions #355

nickbeaird opened this issue Oct 22, 2020 · 6 comments · Fixed by #361
Assignees
Labels
pbv: 0.3 Issues that were on VRMS v0.3 Development role: Back End

Comments

@nickbeaird
Copy link
Contributor

nickbeaird commented Oct 22, 2020

The recent magic link work was done quickly and requires some follow up. We aim to increase the testing and confidence of the backend and make sure that the methods are well named and communicated. I am making sure that the endpoints work as expected and cleaning up the organization along the way.

@nickbeaird nickbeaird self-assigned this Oct 22, 2020
@alex-anakin alex-anakin added this to the Sprint 10.19 - 11.2 milestone Oct 23, 2020
@nickbeaird
Copy link
Contributor Author

nickbeaird commented Oct 23, 2020

Do we need the answers Model? It is not being referenced anywhere. Any thoughts @alex-anakin ?

I added a commit to remove the Answer Model as it is not being called and the Question Model looks to have been refactored to house this information.

@nickbeaird
Copy link
Contributor Author

nickbeaird commented Oct 24, 2020

Suggestion # 2: We should get rid of the Checkin model and move the list of attendees over to the event model. That and improve the attendee list in general. We should review what we need, because it seems like two paths.

  • Path 1 Projects: We need a list of people on the project. Add an array of user IDs on the project. This is likely a smaller list each person is an active VRMS member.
  • Path 2 Events: We would want to know a few things.
  • The count of people at the event
  • The count of people at an event that are not a part of a project. Potentially compute heavy with how we structure our evenst.
  • A list of emails to reach out to for future follow up who have joined an event, but are not part of a project.

What are your thoughts to the above Adam (not sure on your github username) and @alex-anakin ?

@nickbeaird
Copy link
Contributor Author

Suggestion # 3: We should move all checkUser api routes over to pathways on Auth, and we should verify the user's permissions when we do.

@switchzer0
Copy link
Contributor

@nickbeaird Adam here.

  • Question/Answer models: There is no functionality I'm aware of scoped for the next ~year that would require either model.
  • Event/Checkin models: there are some reasons that I found to be persuasive for having these models separate, but I don't recall in detail. Coincidentally given your question, there is a meeting proposed to finalize the parameters for both of these models and their relationship within the database schema on this coming Tuesday eve. Would be great if you could attend that in addition to discussing here. I'll bump the RSVP request in our slack channel.

@nickbeaird
Copy link
Contributor Author

Great, once you know what you all hope to have, then I can move things around to organize the data.

@nickbeaird
Copy link
Contributor Author

Progress: This is done. We had a data model checkin this last week, which answered a lot of the questions that I had.

This will be done as soon after this meeting.

@JackHaeg JackHaeg added the pbv: 0.3 Issues that were on VRMS v0.3 Development label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pbv: 0.3 Issues that were on VRMS v0.3 Development role: Back End
Projects
Development

Successfully merging a pull request may close this issue.

4 participants