-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor backend for magic link additions #355
Comments
Do we need the answers Model? It is not being referenced anywhere. Any thoughts @alex-anakin ? I added a commit to remove the Answer Model as it is not being called and the Question Model looks to have been refactored to house this information. |
Suggestion # 2: We should get rid of the Checkin model and move the list of attendees over to the event model. That and improve the attendee list in general. We should review what we need, because it seems like two paths.
What are your thoughts to the above Adam (not sure on your github username) and @alex-anakin ? |
Suggestion # 3: We should move all checkUser api routes over to pathways on Auth, and we should verify the user's permissions when we do. |
@nickbeaird Adam here.
|
Great, once you know what you all hope to have, then I can move things around to organize the data. |
Progress: This is done. We had a data model checkin this last week, which answered a lot of the questions that I had. This will be done as soon after this meeting. |
The recent magic link work was done quickly and requires some follow up. We aim to increase the testing and confidence of the backend and make sure that the methods are well named and communicated. I am making sure that the endpoints work as expected and cleaning up the organization along the way.
The text was updated successfully, but these errors were encountered: