-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Submit Snapshot Form and Main Menu Item to select it. #1655
Comments
@heejung-hong was stuck on how to get the target vs earned points for each project (it's not easy) and submitted a partial solution for me to help with on 10/30/24. I have not been able to work on this yet, but it may require us to to save the calculation result to the database when a project is modified, instead of trying to re-compute all the projects when they appear on this page (this is also a problem on the My Projects Page), to improve performance and simplify issues that need to process sets of calculations based on elements in the results of the calculation. |
I did not mean to close this issue, as we still need work on the User Interface for the Submit Snapshot form to make it look like the designed wireframes. |
|
This is partially complete, but I'm going to put this back in the Backlog and let someone else take over this issue to finish the UI:
|
@heejung-hong Please provide update
|
1. Progress: The submit snapshot button is implemented and the date submitted fields are updated. |
"Ready for your submission!" modalThe proposed modal above has a number of design issues.
I will need to write an issue to have someone on the design team fix these problems. I will update this issue with a comment once one has been written. If you'd like, you can make this issue dependent on that issue once I've written it. I will also have to make sure that the updated modal design is included in #1977 . Submit Snapshot tables UIFrom a functional perspective, it looks like the tables on the Submit Snapshot page on the Dev site work as shown in the #1407 mockup. Mockup from #1407![]() However, stylistically, there are a few mismatches between the Dev site and the mockup, namely header labels not being bold, columns and tables not having consistent or enough spacing, and snapshot names not having links. If you'd like, we can write these as separate bugs. Please also be aware that design changes are also forthcoming for the tables on the Submit Snapshot page via #2004 , though that issue applies specifically to table headers. |
@heejung-hong The "Ready for your submission!" modal design issue has been written as #2031 . |
Hi @thetanmancan, I'll wait for the modal and table design to be completed, to finish this issue. Thank you |
Sounds good, @heejung-hong . Would you like me to add those dependencies to this issue and move this to the ice box? |
Hi @thetanmancan, This issue doesn't need to be added to the ice box at this time. The dependencies are already referenced, so I'm good. Thank you |
@heejung-hong we are going to close this issue because it's going to take 3 weeks for design to come up with a new table design. So we will just make a new issue for it and also take care of the modal on another issue |
Appeared in the 2024-12-03 Stakeholder deck and was approved. Has been added to the Approved by Stakeholder, To be Pushed to Prod deck |
Overview
Users should be able to go to a page where all of their completed forms are available to be selected and submitted to LA City Planning Department for review.
Action Items
The web api endpoint /api/projects/submit was implemented under Issue Create Web API endpoints to support Submitting a Project for Approval #1704.
Create Snapshot Submittal Form page.

Create successful submission modal.

Review with product and dev. Update if needed based on feedback
Once finalized, add before and after images to the staging deck on this slide
Get Stakeholder sign-off via the stakeholder meeting slide deck.
Resources/Instructions
Figma
Requirements for submission
The text was updated successfully, but these errors were encountered: