Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: FAQ page's "Unsaved changes" modal has incorrect red colors #2012

Closed
4 tasks
thetanmancan opened this issue Jan 6, 2025 · 1 comment · Fixed by #2127
Closed
4 tasks

Bug: FAQ page's "Unsaved changes" modal has incorrect red colors #2012

thetanmancan opened this issue Jan 6, 2025 · 1 comment · Fixed by #2127
Labels
Milestone

Comments

@thetanmancan
Copy link
Member

thetanmancan commented Jan 6, 2025

Describe the bug

This comment in issue #1896 establishes the design of the "Unsaved changes" modal on the FAQ page. However, the implementation of the modal on the Dev site uses different red colors than are in the design.

Steps to reproduce the issue

  1. Log into the Dev site using an Admin account.
  2. Navigate to the FAQ page.
  3. Click the "Edit FAQ Page" button.
  4. Make an edit to the page.
  5. Attempt to navigate to another page within the Dev site.

What's the expected result?

The warning icon and Proceed button should use the color #C3391D.

Figma mockup of "Unsaved changes" modal's intended design with #C3391D colors

FAQ navigation confirm Modal

What's the actual result?

The warning icon uses the color #B64E38.
The Proceed button uses the color rgb(228, 98, 71)

Current implementation of "Unsaved changes" modal

Image

Device configuration

  • Device: Desktop
  • OS version: Windows 11
  • Browser: Firefox
  • Browser version: 133.0.3

Additional Resources

Action Items

  • Make code changes that change the actual results to conform with the expected results.
  • Review changes with product and dev. Update if needed based on feedback.
  • Make a slide on the the staging deck
  • Get Stakeholder sign-off via the stakeholder meeting slide deck.
@entrotech
Copy link
Member

After screenshot:

Image

@github-project-automation github-project-automation bot moved this from Prioritized Backlog to On Dev-not yet pushed to Prod in P: TDM: project board Feb 16, 2025
@entrotech entrotech moved this from On Dev-not yet pushed to Prod to Released in P: TDM: project board Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants