Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Tooltip incorrectly displayed on Packages on the strategy seleciton page (calculation/5) #940

Closed
2 tasks done
KPHowley opened this issue Sep 18, 2021 · 1 comment · Fixed by #961
Closed
2 tasks done

Bug: Tooltip incorrectly displayed on Packages on the strategy seleciton page (calculation/5) #940

KPHowley opened this issue Sep 18, 2021 · 1 comment · Fixed by #961
Assignees
@fyliu
Labels
bug Release Note: Shows as Error Correction good first issue Good for newcomers level: easy p-feature: Tool Tips priority: MUST HAVE role: front-end Front End Developer size: missing

Comments

@KPHowley
Copy link
Member

KPHowley commented Sep 18, 2021 •
edited by fyliu
Loading

Overview

Currently there are tool tips displayed on the bonus packages on the strategies page. We should eliminate tool tips and not have them displayed here.

Action Items

  • Eliminate tool tip on bonus packages
  • Look into why this happened to prevent in the future (are tool tips automatically added when the tool tip field in the database is filled out?)

Resources/Instructions

Screen Shot 2021-09-18 at 11 17 34 AM
@KPHowley KPHowley added p-feature: Tool Tips bug Release Note: Shows as Error Correction priority: MUST HAVE level: medium role: back-end Node/Express Development Task labels Sep 18, 2021
@fyliu
Copy link
Member

fyliu commented Sep 18, 2021 •
edited
Loading

@KPHowley do you mean the icons or the actual tool tips as well?

The tool tips are displayed when the field is filled out in the DB as far as I know.

As for the icons, I made them hidden for the strategies page a while ago because someone(maybe you?) told me to. Because every strategy has a tooltip so I guess there's no need to make the UI look more complicated.

Maybe I missed the packages case in my issue and the review didn't catch it. We should add an automated test case for something like this.

@entrotech entrotech added role: front-end Front End Developer good first issue Good for newcomers level: easy and removed role: back-end Node/Express Development Task level: medium labels Sep 23, 2021
@fyliu fyliu self-assigned this Sep 24, 2021
@fyliu fyliu mentioned this issue Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyliu fyliu

Labels
bug Release Note: Shows as Error Correction good first issue Good for newcomers level: easy p-feature: Tool Tips priority: MUST HAVE role: front-end Front End Developer size: missing
Projects
P: TDM: project board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide tooltip icon for package strategies hackforla/tdm-calculator
4 participants
@fyliu @entrotech @KPHowley @Rabia2219