Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget: motorcycle_accidents_vs_all_accidents #1579

Closed
atalyaalon opened this issue Nov 7, 2020 · 5 comments · Fixed by #1635
Closed

Widget: motorcycle_accidents_vs_all_accidents #1579

atalyaalon opened this issue Nov 7, 2020 · 5 comments · Fixed by #1635
Assignees

Comments

@atalyaalon
Copy link
Collaborator

Name
Query for severe and fatal motorcycle accidents VS other accidents in a specific road vs all of the interurban roads

Title
תאונות אופנועים קשות וקטלניות בכביש __ בהשוואה לכל הארץ
(שם הכותרת משתנה כתלות במספר כביש)

Visualization
@MichalOren please attach :)

Visualization explanation
Visualization contains 2 bar graphs (for the specific road and for all of Israel interurban roads)
Each bar is a stacked bar completing to 100% containing the the percentage of severe and fatal accidents with motorcycles and the rest - all other severe and fatal accidents.

Use case
When the percentage of motorcycle accidents in the specific road is greater than 1.5 times the percentage of the motorcycle accidents in all of the roads (for example, if all interurban roads have a 20% of motorcycle severe and fatal accidents, infographics will be presented if the specific road has at least 30% of motorcycle accidents)

SQL query
See query here
Road number changes - according to the newsflash road1 field. Also title changes accordingly.

Additional context

  • Definition will be used by BE team to generate a Json response to FE
  • Mock Json already exists in code (look for motorcycle_accidents_vs_all_accidents in infographics_utils.py)
  • Definition will be provided by Data team, after internal review
  • Definition will be written in English and should use language agnostic definitions and data structures
    (e.g. SQL columns) as much as possible.
@MichalOren
Copy link
Collaborator

Moto4

@MichalOren
Copy link
Collaborator

@atalyaalon
Usually the analysis have specific time frame. I wonder if we should include constatnt 'time reference' in infographic slides and jsons ?
as part of standartization...
i cant find reference to the time frame of the analysis it in the website slides

@atalyaalon
Copy link
Collaborator Author

@MichalOren you are absolutely right - we'll already asked from the FE to add the dates in the bottom of each infographics.

@atalyaalon
Copy link
Collaborator Author

atalyaalon commented Nov 16, 2020

@MichalOren infographic looks really good. Thank you!

@atalyaalon
Copy link
Collaborator Author

Thank you @rsperer and @MichalOren !
Issue was opened to FE team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment