Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seperate fields for configuring autoscaler scale-up and scale-down #441

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Jul 19, 2024

Description

This PR adds separate fields so that the cooldown period can be controlled separately for scaling up and scaling down.

Tests

Usage Example

apiVersion: app.terraform.io/v1alpha2
kind: AgentPool
metadata:
  name: this
spec:
  name: this
  organization: kubernetes-operator
  token:
    secretKeyRef:
      name: tfc-operator
      key: token
  agentTokens:
    - name: alpha
  autoscaling:
    maxReplicas: 4
    minReplicas: 0
    cooldownPeriod:
      scaleUpSeconds: 30
      scaleDownSeconds: 1800
  agentDeployment:
    replicas: 0

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added documentation Improvements or additions to documentation size/L and removed size/XL labels Jul 22, 2024
@jrhouston jrhouston marked this pull request as ready for review July 23, 2024 15:02
@jrhouston jrhouston requested a review from a team as a code owner July 23, 2024 15:02
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀 I will wait for tests to pass and then merge this change.

@arybolovlev arybolovlev merged commit 19ee7ab into main Jul 25, 2024
7 checks passed
@arybolovlev arybolovlev deleted the scaleup-scaledown branch July 25, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 AgentPool has separate levers for cooldownPeriodSeconds and scalingPeriodSeconds
2 participants