Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test: aws_route_table unexpected error message #15274

Closed
gdavison opened this issue Sep 22, 2020 · 5 comments · Fixed by #15261
Closed

Acceptance test: aws_route_table unexpected error message #15274

gdavison opened this issue Sep 22, 2020 · 5 comments · Fixed by #15261
Assignees
Labels
service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@gdavison
Copy link
Contributor

When an empty set of routes is passed to aws_route_table, it expects the following error message from the AWS API

The request must contain the parameter destinationCidrBlock or destinationIpv6CidrBlock

This still passes in GovCloud, but the Commercial partition now supports destinationPrefixListId, so the error message is now

The request must contain exactly one of: destinationCidrBlock, destinationIpv6CidrBlock, destinationPrefixListId

This should be validated in Terraform, not by the API.

Affected Resource

  • aws_route_table
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 22, 2020
@gdavison gdavison self-assigned this Sep 22, 2020
@ewbankkit
Copy link
Contributor

@gdavison I have fixed this in #14013.

@gdavison
Copy link
Contributor Author

Heh, I also fixed it in #15261, @ewbankkit

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 22, 2020

No worries. I'll remove Closes: from #14013 and will rebase after #15261 is merged.

@gdavison gdavison added this to the v3.9.0 milestone Sep 25, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
2 participants