Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPC liveness/readiness/startup_probe #1915

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

dgnemo
Copy link
Contributor

@dgnemo dgnemo commented Nov 30, 2022

Description

Add GRPC liveness/readiness/startup_probe

see: https://github.com/bowei/enhancements/blob/master/keps/sig-node/2727-grpc-probe/

Feature Request: #1908

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKubernetesPod_with_container_liveness_probe_using_grpc'
==> Checking that code complies with gofmt requirements...
go vet .
TF_ACC=1 go test "/home/diego/github/terraform-provider-kubernetes/kubernetes" -v -run=TestAccKubernetesPod_with_container_liveness_probe_using_grpc -timeout 3h
=== RUN   TestAccKubernetesPod_with_container_liveness_probe_using_grpc
--- PASS: TestAccKubernetesPod_with_container_liveness_probe_using_grpc (11.30s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   11.342s

Release Note

Release note for CHANGELOG:

Add support for GRPC probes.  KEP-2727

References

K8s feature:

Feature Request: #1908

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@dgnemo dgnemo requested a review from a team as a code owner November 30, 2022 17:25
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 30, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgnemo,

All looks good, just one more query from my end.

Could you please add a changelog file so we can then auto-generate change log for the upcoming release?

It will be a simple text file in .changelog folder. Like this: .changelog/1915.txt. With the following content:

```release-note:enhancement
Add a new optional attribute `grpc` to `pod.spec.container.liveness_probe`, `pod.spec.container.readiness_probe`, and `pod.spec.container.startup_probe`. That affects all resources and data sources that use mentioned `pod.spec.container` probes directly or as a template.
```

Thank you! 👍🏻

@dgnemo
Copy link
Contributor Author

dgnemo commented Jan 18, 2023

Thanks @arybolovlev

Added the changelog.

@arybolovlev arybolovlev self-requested a review January 18, 2023 10:44
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgnemo,

Looks great! Thank you and congratulations on the first-time contribution to the Kubernetes provider! 🎉

Your changes will be available in the upcoming release. Please keep an eye on the release notes.

@arybolovlev arybolovlev merged commit 241d31d into hashicorp:main Jan 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants