-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GRPC liveness/readiness/startup_probe #1915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dgnemo,
All looks good, just one more query from my end.
Could you please add a changelog file so we can then auto-generate change log for the upcoming release?
It will be a simple text file in .changelog
folder. Like this: .changelog/1915.txt
. With the following content:
```release-note:enhancement
Add a new optional attribute `grpc` to `pod.spec.container.liveness_probe`, `pod.spec.container.readiness_probe`, and `pod.spec.container.startup_probe`. That affects all resources and data sources that use mentioned `pod.spec.container` probes directly or as a template.
```
Thank you! 👍🏻
Thanks @arybolovlev Added the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dgnemo,
Looks great! Thank you and congratulations on the first-time contribution to the Kubernetes provider! 🎉
Your changes will be available in the upcoming release. Please keep an eye on the release notes.
Description
Add GRPC liveness/readiness/startup_probe
see: https://github.com/bowei/enhancements/blob/master/keps/sig-node/2727-grpc-probe/
Feature Request: #1908
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
K8s feature:
Feature Request: #1908
Community Note