Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alpine 3.21 (NodeJS 22) #751

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Update to Alpine 3.21 (NodeJS 22) #751

merged 1 commit into from
Feb 16, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 16, 2025

Proposed Changes

SSIA

Summary by CodeRabbit

  • Chores
    • Updated dependency configuration to align with the latest Alpine Linux version.
    • Upgraded the container base image and refreshed key package versions for improved stability and performance.
    • Synchronized build settings across all supported architectures for consistent deployment.

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Feb 16, 2025
Copy link

coderabbitai bot commented Feb 16, 2025

Walkthrough

This pull request updates version identifiers across configuration and build files. The .github/renovate.json file now uses "alpine_3_21/{{package}}" for the repology datasource. In the zwave-js-ui directory, both the Dockerfile and build.yaml have been updated to use a new base image (ghcr.io/hassio-addons/base:17.2.1 instead of the previous Node.js image) and several package versions in the Dockerfile have been revised or newly added.

Changes

File(s) Change Summary
.github/renovate.json Updated depNameTemplate for the repology datasource from "alpine_3_19/{{package}}" to "alpine_3_21/{{package}}".
zwave-js-ui/... Replaced base image from ghcr.io/hassio-addons/base-nodejs:0.2.5 to ghcr.io/hassio-addons/base:17.2.1 in both Dockerfile and build.yaml; updated package versions in Dockerfile (linux-headers, python3-dev, eudev, libusb, nginx) and added nodejs and npm.

Suggested labels

no-stale

Poem

I'm a bunny who loves a fresh start,
Hopping through configs with a joyful heart.
Alpine versions now leap to a brand new day,
Docker and build files all in bright array.
With every updated line, I cheer and play! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c3725a and 2e07509.

📒 Files selected for processing (3)
  • .github/renovate.json (1 hunks)
  • zwave-js-ui/Dockerfile (2 hunks)
  • zwave-js-ui/build.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • zwave-js-ui/build.yaml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
🔇 Additional comments (4)
.github/renovate.json (1)

28-28: Alpine Version Update in depNameTemplate

The depNameTemplate for the repology datasource has been updated from "alpine_3_19/{{package}}" to "alpine_3_21/{{package}}". This change correctly reflects the upgrade to Alpine 3.21. Please ensure that any dependencies or references to Alpine versions elsewhere in the project are updated consistently.

zwave-js-ui/Dockerfile (3)

1-1: Update Base Image

The base image is now set to ghcr.io/hassio-addons/base:17.2.1, replacing the older NodeJS-specific image. This update aligns with the overall upgrade strategy. Make sure that all subsequent build and runtime processes are compatible with this new image.


19-20: Update Build Dependencies Versions

The versions for linux-headers and python3-dev have been updated to 6.6-r1 and 3.12.9-r0, respectively. These modifications should be verified against the compatibility requirements of the new Alpine base image to ensure a smooth build.


23-27: Refresh Runtime Package Versions and Add NodeJS/NPM

Several runtime dependencies have been updated:

  • eudev from 3.2.14-r1 to 3.2.14-r5
  • libusb from 1.0.26-r3 to 1.0.27-r0
  • nginx from 1.24.0-r16 to 1.26.2-r4

Additionally, new packages nodejs (22.13.1-r0) and npm (10.9.1-r0) have been added. These changes support the NodeJS 22 upgrade and the overall update to Alpine 3.21. It is important to test these updated dependencies to verify they do not introduce any undesired runtime behavior.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit e772c6f into main Feb 16, 2025
22 checks passed
@frenck frenck deleted the frenck-2025-0077 branch February 16, 2025 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant