Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compile source folder specified and return early if type is not cucumber #42

Closed
wants to merge 1 commit into from

Conversation

kinwahlai
Copy link

I encounter a problem when trying to run "test-app unit:" with sources set in CucumberConfig.
I put a check into the event to skip compiling the sources folder if it is not cucumber test

@hauner
Copy link
Owner

hauner commented Jun 28, 2015

Hi,
that's an interesting bug. Thanks for reporting!

I didn't notice the event is called for every testType. That makes it possible to drop the explicit loading of the testType.

eventTestCompileEnd = { testType ->
    if (testType.toString() != 'cucumber') {
        return
    }

    List sourceDirs = testType.getGlueSources ()
    // .....
}

hauner added a commit that referenced this pull request Jun 28, 2015
@hauner
Copy link
Owner

hauner commented Jun 28, 2015

fixed.

@hauner hauner closed this Jun 28, 2015
@hauner hauner added this to the 1.2.0 milestone Jul 12, 2015
@hauner
Copy link
Owner

hauner commented Jul 12, 2015

released 1.2.0 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants