Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SplitScheduler and DefaultNamespaceBundleSplitStrategyImpl #30

Closed
wants to merge 6 commits into from

Conversation

heesung-sn
Copy link
Owner

@heesung-sn heesung-sn commented Feb 11, 2023

Master Issue: apache#16691

Motivation

We will start raising PRs to implement PIP-192, apache#16691

Modifications

This PR implemented SplitScheduler, DefaultNamespaceBundleSplitStrategyImpl, and their unit test.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • *Added unit tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

We will have separate PRs to update the Doc later.

Matching PR in forked repository

PR in forked repository: #30

@heesung-sn heesung-sn force-pushed the pip-192-split-shceduler branch 2 times, most recently from 944d891 to a72fb59 Compare February 24, 2023 02:50
@heesung-sn heesung-sn changed the title temp for SplitManager Added SplitManager Feb 24, 2023
@heesung-sn heesung-sn force-pushed the pip-192-split-shceduler branch from a72fb59 to 73be2ba Compare February 24, 2023 03:01
@heesung-sn heesung-sn changed the title Added SplitManager Added SplitManager and DefaultNamespaceBundleSplitStrategyImpl Feb 24, 2023
@heesung-sn heesung-sn changed the title Added SplitManager and DefaultNamespaceBundleSplitStrategyImpl Added SplitScheduler and DefaultNamespaceBundleSplitStrategyImpl Feb 24, 2023
@heesung-sn heesung-sn force-pushed the pip-192-split-shceduler branch from 73be2ba to c856344 Compare March 8, 2023 02:14
@heesung-sn heesung-sn force-pushed the pip-192-split-shceduler branch from e71ea9f to 1ac2868 Compare March 9, 2023 05:22
@heesung-sn heesung-sn closed this Mar 21, 2023
@heesung-sn heesung-sn deleted the pip-192-split-shceduler branch April 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant