Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one error when selecting start or end of lines when selection followed by empty line #3544

Closed
aral opened this issue Aug 25, 2022 · 0 comments · Fixed by #3598
Closed
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@aral
Copy link
Contributor

aral commented Aug 25, 2022

Summary

An extra cursor gets created when a start of line/end of line search is carried out on a selection that is followed by an empty line.

Reproduction Steps

With the following text:

1. console.log('hello')
2. 

Run these commands to select line 1 and search for start of line within it:

g1g
x
s
^
<return>

What should happen

One cursor should be created (on line 1)

What actually happens

Two cursors are created (one on line 1 and one on line 2).

(The same happens if you search for end of line using $.)

Helix log

n/a

Platform

Linux (Fedora Silverblue 36)

Terminal Emulator

Black Box

Helix Version

helix 22.05 (e4c9d40)

@aral aral added the C-bug Category: This is a bug label Aug 25, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants