[sandbox] Enable the sandbox by default in gm.py

Since enabling the sandbox is now required for example for mkgrokdump, add it to the default gn args. Also treat non-sandbox builds as "non-shipping" in mkgrokdump.cc Bug: v8:13281 Change-Id: I08042aa53057e25c556e166c059373e2fdb9d2c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899317 Commit-Queue: Samuel Groß <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#83231}
hexagon-geo-surv · Sep 15, 2022 · 2cc1f9a · 2cc1f9a
1 parent 80fb281
commit 2cc1f9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/test/mkgrokdump/mkgrokdump.cc b/test/mkgrokdump/mkgrokdump.cc
@@ -31,7 +31,7 @@ static const char* kHeader =
     "# yapf: disable\n\n";
 
 // Debug builds emit debug code, affecting code object sizes.
-#ifndef DEBUG
+#if !defined(DEBUG) && defined(V8_ENABLE_SANDBOX)
 static const char* kBuild = "shipping";
 #else
 static const char* kBuild = "non-shipping";

diff --git a/tools/dev/gm.py b/tools/dev/gm.py
@@ -169,6 +169,7 @@ def DetectGoma():
 v8_enable_object_print = true
 v8_enable_verify_heap = true
 dcheck_always_on = false
+v8_enable_sandbox = true
 """.replace("{GOMA}", USE_GOMA)
 
 DEBUG_ARGS_TEMPLATE = """\
@@ -181,6 +182,7 @@ def DetectGoma():
 v8_enable_fast_mksnapshot = true
 v8_enable_slow_dchecks = true
 v8_optimized_debug = false
+v8_enable_sandbox = true
 """.replace("{GOMA}", USE_GOMA)
 
 OPTDEBUG_ARGS_TEMPLATE = """\
@@ -193,6 +195,7 @@ def DetectGoma():
 v8_enable_fast_mksnapshot = true
 v8_enable_verify_heap = true
 v8_optimized_debug = true
+v8_enable_sandbox = true
 """.replace("{GOMA}", USE_GOMA)
 
 ARGS_TEMPLATES = {