From 2cc1f9a3d3c6129be67b28accb0c519823f05695 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20Gro=C3=9F?= Date: Thu, 15 Sep 2022 14:31:03 +0000 Subject: [PATCH] [sandbox] Enable the sandbox by default in gm.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since enabling the sandbox is now required for example for mkgrokdump, add it to the default gn args. Also treat non-sandbox builds as "non-shipping" in mkgrokdump.cc Bug: v8:13281 Change-Id: I08042aa53057e25c556e166c059373e2fdb9d2c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899317 Commit-Queue: Samuel Groß Reviewed-by: Jakob Kummerow Cr-Commit-Position: refs/heads/main@{#83231} --- test/mkgrokdump/mkgrokdump.cc | 2 +- tools/dev/gm.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/test/mkgrokdump/mkgrokdump.cc b/test/mkgrokdump/mkgrokdump.cc index 800964e26e17..f39aac6709a7 100644 --- a/test/mkgrokdump/mkgrokdump.cc +++ b/test/mkgrokdump/mkgrokdump.cc @@ -31,7 +31,7 @@ static const char* kHeader = "# yapf: disable\n\n"; // Debug builds emit debug code, affecting code object sizes. -#ifndef DEBUG +#if !defined(DEBUG) && defined(V8_ENABLE_SANDBOX) static const char* kBuild = "shipping"; #else static const char* kBuild = "non-shipping"; diff --git a/tools/dev/gm.py b/tools/dev/gm.py index 58a729045aec..e2d958a19113 100755 --- a/tools/dev/gm.py +++ b/tools/dev/gm.py @@ -169,6 +169,7 @@ def DetectGoma(): v8_enable_object_print = true v8_enable_verify_heap = true dcheck_always_on = false +v8_enable_sandbox = true """.replace("{GOMA}", USE_GOMA) DEBUG_ARGS_TEMPLATE = """\ @@ -181,6 +182,7 @@ def DetectGoma(): v8_enable_fast_mksnapshot = true v8_enable_slow_dchecks = true v8_optimized_debug = false +v8_enable_sandbox = true """.replace("{GOMA}", USE_GOMA) OPTDEBUG_ARGS_TEMPLATE = """\ @@ -193,6 +195,7 @@ def DetectGoma(): v8_enable_fast_mksnapshot = true v8_enable_verify_heap = true v8_optimized_debug = true +v8_enable_sandbox = true """.replace("{GOMA}", USE_GOMA) ARGS_TEMPLATES = {