[turboshaft] Sound effects for FindOrderedHashEntry call descriptor

Bug: v8:12783, chromium:1489500, chromium:1507235 Change-Id: I4e32481eda78c0a55c5e80514d51492717e85f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5082001 Auto-Submit: Nico Hartmann <[email protected]> Reviewed-by: Darius Mercadier <[email protected]> Commit-Queue: Darius Mercadier <[email protected]> Commit-Queue: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#91325}
hexagon-geo-surv · Dec 4, 2023 · 7d12441 · 7d12441
1 parent a8774c0
commit 7d12441
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/compiler/turboshaft/builtin-call-descriptors.h b/src/compiler/turboshaft/builtin-call-descriptors.h
@@ -125,7 +125,10 @@ struct BuiltinCallDescriptor {
     static constexpr bool kNeedsFrameState = false;
     static constexpr bool kNeedsContext = true;
     static constexpr Operator::Properties kProperties = Operator::kEliminatable;
-    static constexpr OpEffects kEffects = base_effects.CanReadMemory();
+    // TODO(chromium:1489500, nicohartmann@): We can probably relax this to
+    // base_effects.AssumesConsistentHeap().CanReadMemory() but for now we go
+    // with stronger effects until we better understand the recent crashes.
+    static constexpr OpEffects kEffects = OpEffects().CanCallAnything();
   };
   using FindOrderedHashMapEntry =
       FindOrderedHashEntry<Builtin::kFindOrderedHashMapEntry>;