From 7d12441af90c25e9a9a9a5d188dc39dfa552f215 Mon Sep 17 00:00:00 2001 From: Nico Hartmann Date: Mon, 4 Dec 2023 13:45:06 +0100 Subject: [PATCH] [turboshaft] Sound effects for FindOrderedHashEntry call descriptor Bug: v8:12783, chromium:1489500, chromium:1507235 Change-Id: I4e32481eda78c0a55c5e80514d51492717e85f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5082001 Auto-Submit: Nico Hartmann Reviewed-by: Darius Mercadier Commit-Queue: Darius Mercadier Commit-Queue: Nico Hartmann Cr-Commit-Position: refs/heads/main@{#91325} --- src/compiler/turboshaft/builtin-call-descriptors.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/turboshaft/builtin-call-descriptors.h b/src/compiler/turboshaft/builtin-call-descriptors.h index bb7e79ee8686..08fe6e903eaf 100644 --- a/src/compiler/turboshaft/builtin-call-descriptors.h +++ b/src/compiler/turboshaft/builtin-call-descriptors.h @@ -125,7 +125,10 @@ struct BuiltinCallDescriptor { static constexpr bool kNeedsFrameState = false; static constexpr bool kNeedsContext = true; static constexpr Operator::Properties kProperties = Operator::kEliminatable; - static constexpr OpEffects kEffects = base_effects.CanReadMemory(); + // TODO(chromium:1489500, nicohartmann@): We can probably relax this to + // base_effects.AssumesConsistentHeap().CanReadMemory() but for now we go + // with stronger effects until we better understand the recent crashes. + static constexpr OpEffects kEffects = OpEffects().CanCallAnything(); }; using FindOrderedHashMapEntry = FindOrderedHashEntry;