[wasm-gc] JS interop: Test for deopt loops

Ensure that no deopt-loops happen for wasm objects used in JS on all operations excluding a few corner cases that have not yet been adapted. Bug: v8:7748 Change-Id: I43226115a65acacc6cf78d057513ac03a48ce786 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4615032 Commit-Queue: Matthias Liedtke <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#88340}
hexagon-geo-surv · Jun 19, 2023 · 95cbef2 · 95cbef2
1 parent 4f096d4
commit 95cbef2
Show file tree

Hide file tree

Showing 10 changed files with 44 additions and 21 deletions.
diff --git a/test/mjsunit/wasm/gc-js-interop-async-debugger.js b/test/mjsunit/wasm/gc-js-interop-async-debugger.js
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 // The implementation of Promises currently takes a different path (a C++
 // runtime function instead of a Torque builtin) when the debugger is

diff --git a/test/mjsunit/wasm/gc-js-interop-async.js b/test/mjsunit/wasm/gc-js-interop-async.js
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 

diff --git a/test/mjsunit/wasm/gc-js-interop-collections.js b/test/mjsunit/wasm/gc-js-interop-collections.js
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 

diff --git a/test/mjsunit/wasm/gc-js-interop-global-constructors.js b/test/mjsunit/wasm/gc-js-interop-global-constructors.js
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 

diff --git a/test/mjsunit/wasm/gc-js-interop-helpers.js b/test/mjsunit/wasm/gc-js-interop-helpers.js
@@ -4,6 +4,10 @@
 
 // Helpers to test interoperability of Wasm objects in JavaScript.
 
+// The following flags are required:
+// Flags: --turbofan --no-always-turbofan --experimental-wasm-gc
+// Flags: --allow-natives-syntax
+
 d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
 
 function CreateWasmObjects() {
@@ -32,22 +36,26 @@ function CreateWasmObjects() {
   };
 }
 
-function testThrowsRepeated(fn, ErrorType) {
-  %PrepareFunctionForOptimization(fn);
-  for (let i = 0; i < 5; i++) assertThrows(fn, ErrorType);
-  %OptimizeFunctionOnNextCall(fn);
-  assertThrows(fn, ErrorType);
-  // TODO(7748): This assertion doesn't hold true, as some cases run into
-  // deopt loops.
-  // assertTrue(%ActiveTierIsTurbofan(fn));
+function testThrowsRepeated(fn, ErrorType, ignoreDeopts = false) {
+  const maxRuns = 2;
+  for (let run = 0; run < maxRuns; ++run) {
+    %PrepareFunctionForOptimization(fn);
+    for (let i = 0; i < 5; i++) assertThrows(fn, ErrorType);
+    %OptimizeFunctionOnNextCall(fn);
+    assertThrows(fn, ErrorType);
+    if (isOptimized(fn) || ignoreDeopts) return;
+  }
+  assertOptimized(fn);
 }
 
-function repeated(fn) {
-  %PrepareFunctionForOptimization(fn);
-  for (let i = 0; i < 5; i++) fn();
-  %OptimizeFunctionOnNextCall(fn);
-  fn();
-  // TODO(7748): This assertion doesn't hold true, as some cases run into
-  // deopt loops.
-  // assertTrue(%ActiveTierIsTurbofan(fn));
+function repeated(fn, ignoreDeopts = false) {
+  const maxRuns = 2;
+  for (let run = 0; run < maxRuns; ++run) {
+    %PrepareFunctionForOptimization(fn);
+    for (let i = 0; i < 5; i++) fn();
+    %OptimizeFunctionOnNextCall(fn);
+    fn();
+    if (isOptimized(fn) || ignoreDeopts) return;
+  }
+  assertOptimized(fn);
 }
diff --git a/test/mjsunit/wasm/gc-js-interop-import.mjs b/test/mjsunit/wasm/gc-js-interop-import.mjs
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 import {struct, array} from 'gc-js-interop-export.mjs';
 

diff --git a/test/mjsunit/wasm/gc-js-interop-numeric.js b/test/mjsunit/wasm/gc-js-interop-numeric.js
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 

diff --git a/test/mjsunit/wasm/gc-js-interop-objects.js b/test/mjsunit/wasm/gc-js-interop-objects.js
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 

diff --git a/test/mjsunit/wasm/gc-js-interop-wasm.js b/test/mjsunit/wasm/gc-js-interop-wasm.js
@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --wasm-test-streaming
-// Flags: --allow-natives-syntax
+// Flags: --allow-natives-syntax --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 

diff --git a/test/mjsunit/wasm/gc-js-interop.js b/test/mjsunit/wasm/gc-js-interop.js
@@ -3,9 +3,13 @@
 // found in the LICENSE file.
 
 // Flags: --experimental-wasm-gc --allow-natives-syntax
+// Flags: --turbofan --no-always-turbofan
 
 d8.file.execute('test/mjsunit/wasm/gc-js-interop-helpers.js');
 
+// TODO(14034): Some operations can still trigger a deopt loop.
+const ignoreDeopts = true;
+
 let {struct, array} = CreateWasmObjects();
 for (const wasm_obj of [struct, array]) {
   repeated(() => assertSame(undefined, wasm_obj.foo));
@@ -54,7 +58,9 @@ for (const wasm_obj of [struct, array]) {
   repeated(() => assertSame(undefined, wasm_obj?.property));
 
   repeated(() => assertEquals(undefined, void wasm_obj));
-  testThrowsRepeated(() => 2 == wasm_obj, TypeError);
+  // These deopt loops can also be triggered with JS only code, e.g.
+  // `2 == {valueOf: () => +2n}`.
+  testThrowsRepeated(() => 2 == wasm_obj, TypeError, ignoreDeopts);
   repeated(() => assertFalse(2 === wasm_obj));
   repeated(() => assertFalse({} === wasm_obj));
   repeated(() => assertTrue(wasm_obj == wasm_obj));
@@ -63,9 +69,11 @@ for (const wasm_obj of [struct, array]) {
   repeated(() => assertFalse(wasm_obj !== wasm_obj));
   repeated(() => assertFalse(struct == array));
   repeated(() => assertTrue(struct != array));
-  testThrowsRepeated(() => wasm_obj < wasm_obj, TypeError);
-  testThrowsRepeated(() => wasm_obj <= wasm_obj, TypeError);
-  testThrowsRepeated(() => wasm_obj >= wasm_obj, TypeError);
+  // JS Symbols also have the issue of triggering deopt loops on relational
+  // comparisons, e.g. `2 < Symbol("test")`.
+  testThrowsRepeated(() => wasm_obj < wasm_obj, TypeError, ignoreDeopts);
+  testThrowsRepeated(() => wasm_obj <= wasm_obj, TypeError, ignoreDeopts);
+  testThrowsRepeated(() => wasm_obj >= wasm_obj, TypeError, ignoreDeopts);
 
   testThrowsRepeated(() => { let [] = wasm_obj; }, TypeError);
   testThrowsRepeated(() => { let [a, b] = wasm_obj; }, TypeError);