Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for preemptible nodepools [DEVOP-5845] #137

Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat: Add support for preemptible nodepools [DEVOP-5845] #137

merged 1 commit into from
Feb 7, 2025

Conversation

ChristianWitts
Copy link
Contributor

@ChristianWitts ChristianWitts commented Feb 5, 2025 •
edited by jai
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.
  • All entities that I am working with are up-to-date in Backstage; if updates are needed, I have linked the relevant PRs. Backstage guide

Description

For greater cost efficiency, add support to utilise preemptible
nodepools.

Refs: #DEVOP-5845

Signed-off-by: Christian Witts [email protected]

This change is Reviewable

@ChristianWitts ChristianWitts requested a review from a team as a code owner February 5, 2025 03:15
Sagart-cactus
Sagart-cactus previously approved these changes Feb 5, 2025
View reviewed changes
@ChristianWitts ChristianWitts force-pushed the christian/devop-5845-preemptible-nodepool-support branch 2 times, most recently from 1e78197 to 75ed16d Compare February 5, 2025 03:45
@ChristianWitts ChristianWitts force-pushed the christian/devop-5845-preemptible-nodepool-support branch 2 times, most recently from b3f44d7 to 28dfaed Compare February 5, 2025 04:04
@ChristianWitts
feat: Add support for preemptible nodepools [DEVOP-5845]
93c6b8b 
For greater cost efficiency, add support to utilise preemptible
nodepools.

Refs: #DEVOP-5845

Signed-off-by: Christian Witts <[email protected]>
@ChristianWitts ChristianWitts force-pushed the christian/devop-5845-preemptible-nodepool-support branch from be26d3d to 93c6b8b Compare February 6, 2025 08:48
@ChristianWitts ChristianWitts merged commit 08aa126 into main Feb 7, 2025
6 checks passed
@ChristianWitts ChristianWitts deleted the christian/devop-5845-preemptible-nodepool-support branch February 7, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bibek4699 bibek4699 bibek4699 approved these changes

@sunilhonest sunilhonest sunilhonest approved these changes

@Sagart-cactus Sagart-cactus Sagart-cactus left review comments

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristianWitts @Sagart-cactus @bibek4699 @sunilhonest