Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundles example doesn't work with typed-emitter #299

Closed
hongaar opened this issue Sep 8, 2021 · 2 comments
Closed

Bundles example doesn't work with typed-emitter #299

hongaar opened this issue Sep 8, 2021 · 2 comments
Assignees
Labels
bug Something isn't working upstream Blocked by upstream

Comments

@hongaar
Copy link
Owner

hongaar commented Sep 8, 2021

Running the bundle example from the readme (also in the examples/bundle dir) yields this error:

[email protected]
Error! This experimental syntax requires enabling one of the following parser plugin(s): 'flow, typescript' (1:7)
bandersnatch/examples/bundle/node_modules/typed-emitter/index.d.ts`

This is caused by andywer/typed-emitter#12 and has since been fixed with andywer/typed-emitter#16 but it's still pending a NPM release. Once that's in, we should upgrade typed-emitter and that should resolve this issue.

Related to #295

Thanks @arbue for reporting this!

@hongaar hongaar changed the title bundles example doesn't work with typed-emitter Bundles example doesn't work with typed-emitter Sep 8, 2021
@hongaar hongaar self-assigned this Sep 8, 2021
@hongaar hongaar added bug Something isn't working upstream Blocked by upstream labels Sep 8, 2021
@arbue
Copy link

arbue commented Jan 5, 2022

Hi @hongaar

Just wanted to inform you, that there is a new release in the andywer/typed-emitter package which should resolve this issue:

https://github.com/andywer/typed-emitter/releases/tag/v1.4.0

@hongaar
Copy link
Owner Author

hongaar commented Mar 22, 2022

Fixed with #368

@hongaar hongaar closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Blocked by upstream
Projects
None yet
Development

No branches or pull requests

2 participants