Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bun): conflicts due to changes in Bun specs #79

Closed
wants to merge 1 commit into from
Closed

fix(bun): conflicts due to changes in Bun specs #79

wants to merge 1 commit into from
+3 −1

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Feb 24, 2025 •
edited
Loading

@yusukebe
Copy link
Member

@EdamAme-x

Oops. That Bun does not support export default app means we can't use the same code with Bun and Cloudflare Workers/Deno 😢

Is there any chance to use export default app on Bun? Or can it be the future?

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Feb 25, 2025 •
edited
Loading

The current version does so.

We can issue a PR to Bun for a patch that ignores the case where the key is not a string. (I don't know if it will be merged or not).

@EdamAme-x
Copy link
Contributor Author

hi @yusukebe
Good news here.

oven-sh/bun#17568

Already Patched!
image

@EdamAme-x EdamAme-x closed this Feb 25, 2025
This was referenced Feb 25, 2025
Closed
Closed
@yusukebe
Copy link
Member

@EdamAme-x Woow coo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bun template broken
2 participants
@EdamAme-x @yusukebe