Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{vis}[goolf-1.4.10-Python-2.7.5] Pmw 1.3.3 (REVIEW) #1403

Merged
merged 2 commits into from
Feb 13, 2015
Merged

{vis}[goolf-1.4.10-Python-2.7.5] Pmw 1.3.3 (REVIEW) #1403

merged 2 commits into from
Feb 13, 2015

Conversation

a-mazur
Copy link
Contributor

@a-mazur a-mazur commented Feb 12, 2015

Pmw library is required for fully funcional PyMOL

@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

@a-mazur
Copy link
Contributor Author

a-mazur commented Feb 13, 2015

Test report by @a-mazur
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux centos 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/2ab471551c48c976c19c for a full test report.

@boegel
Copy link
Member

boegel commented Feb 13, 2015

Jenkins: ok to test

boegel
boegel reviewed Feb 13, 2015
View reviewed changes
easybuild/easyconfigs/p/Pmw/Pmw-1.3.3-goolf-1.4.10-Python-2.7.5.eb

toolchain = {'name': 'goolf', 'version': '1.4.10'}

source_urls = ['http://sourceforge.net/projects/%(namelower)s/files/%(name)s/%(name)s.%(version)s/', '/download']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the /download part is not needed?

as it is now, EasyBuild will try to download the source file from /download/Pmw.1.3.3.tar.gz in case the first source URL fails...

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2349/
Test PASSed.

@boegel
Copy link
Member

boegel commented Feb 13, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/f1202d48a6114f53964d for a full test report.

@boegel
Copy link
Member

boegel commented Feb 13, 2015

@a-mazur: looks great, just needs a small fix in the source_urls, should be ready to merge then

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2350/
Test PASSed.

boegel added a commit that referenced this pull request Feb 13, 2015
@boegel
Merge pull request #1403 from a-mazur/pmw
6277116 
{vis}[goolf-1.4.10-Python-2.7.5] Pmw 1.3.3 (REVIEW)
@boegel boegel merged commit 6277116 into easybuilders:develop Feb 13, 2015
@boegel
Copy link
Member

boegel commented Feb 13, 2015

Merged, thanks @a-mazur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-mazur @hpcugentbot @boegel