Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues when updating to 0.3.1 #109

Open
nhinze opened this issue Apr 17, 2017 · 10 comments
Open

Performance issues when updating to 0.3.1 #109

nhinze opened this issue Apr 17, 2017 · 10 comments

Comments

@nhinze
Copy link

nhinze commented Apr 17, 2017

I'm working to update to Leaflet 1.0 and dvf 0.3.1. I used to be on LL 0.7.7 and some version of dvf .2 (at least a year old if not more).

The drawing performance was great. I use FlowLines with CustomColorFunctions. Using the new dvf 0.3.1, it takes a few seconds to draw a FlowLine. My FlowLines have 100s of points.

Are there any known issues? How can I figure out what is slow?

@nhinze nhinze closed this as completed Apr 17, 2017
@sfairgrieve
Copy link
Contributor

@nhinze What was the issue? Just curious.

@nhinze
Copy link
Author

nhinze commented Apr 17, 2017

Closing Chrome and restarting it fixed it. It seems that having the JS Console open slowly creates this slowdown after reloading the page many times.

@nhinze
Copy link
Author

nhinze commented Apr 17, 2017

However, it appears the Chrome is still much slower at drawing dvf than before. I can see the FlowLine being drawn. Firefox has the same speed as Chrome. Safari on the other hand is very fast. This is on Mac. I have not tested Windows yet.

@nhinze nhinze reopened this Apr 17, 2017
@sfairgrieve
Copy link
Contributor

Can you share an example? If not, I can try to recreate it. Just curious on the specifics to help better understand what might be causing the issue.

@nhinze
Copy link
Author

nhinze commented Apr 19, 2017

The LL 1.0 update is not live yet. I'm still doing a lot of testing. It probably will be a week or 2 before it goes live. Here is a link to show you how I'm using dvf using LL 0.77:

https://en.mycoursewalk.com/rides/720

@sfairgrieve
Copy link
Contributor

Very cool app! This example definitely helps. I'll take a look and see if I can figure out what the problem might be.

@sfairgrieve
Copy link
Contributor

Still looking into this. It's not clear why the performance is worse, but it does seem to be. One thing to play around with is the smoothFactor option (add this to layerOptions). Try a value greater than 1. Maybe something like 4 or higher. This seems to improve the performance in my testing.

@sfairgrieve
Copy link
Contributor

@nhinze Did changing smoothFactor help at all? Just curious. Unfortunately, I haven't figured out any other answers at the moment, although I am still investigating.

@nhinze
Copy link
Author

nhinze commented May 4, 2017

I haven't had a chance to test yet. I'm going to get back to it next week. I did test IE11 and Edge. Both work fine. Safari is fine. Need to test Chrome and Firefox on Windows. Chrome and Firefox on Mac are slow.

@nhinze
Copy link
Author

nhinze commented May 12, 2017

I have finally upgraded my app. The loading can be a bit slow in Chrome, but the performance seems ok for now. For my app, I need to keep the smoothFactor at 1.

Thanks for you help. It's a great plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants