Use frame_support::logs APIs
#1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZGIII
reviewed
Nov 7, 2024
Co-authored-by: MOZGIII <[email protected]>
MOZGIII
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
This looks trivial enough, and we can merge it as it would not be a big deal to change it back where these changes are unwarranted after we find out when to use what properly.
So, we can merge it.
Usually, I'd say we're jumping the gun with these changes - but currently, since the with-tracing features are not enabled in places, the logging points we left in the code just don't work, which seems to be an inferior state than before - so gonig forward with this now is justified.
quasiyoke
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up of #1325 (comment)