New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ethereum explicitly related currency swap logic to make Native-to-EVM Bridge transactions visible via Ethereum RPC #1449

Draft

dmitrylavrenov wants to merge 63 commits into master from pallet-visible-currency-swap

+1,864 −1

Contributor

dmitrylavrenov commented Feb 19, 2025 •

edited

Loading

Design thoughts

A new pallet that contains ethereum explicitly related currency swap logic. We need to make Native-to-EVM Bridge transactions visible via Ethereum RPC
Use https://github.com/humanode-network/frontier/blob/174c0227af00dbc26485c1eac68738e1d01980e8/frame/ethereum/src/lib.rs#L964 to make the transaction visible at ethereum side
Avoid using Currency in favour of fungible related traits like Inspect and Mutate

Tasks

PoC of visibility

transaction itself

Screenshot 2025-02-19 at 23 01 35

transaction execution in explorer on Substrate RPC side

Screenshot 2025-02-19 at 23 02 22

transaction execution in explorer on Ethereum RPC side

Very tiny ethereum explorer is used to verify visibility via Ethereum RPC

Screenshot 2025-02-19 at 23 02 43

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

dmitrylavrenov commented

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

dmitrylavrenov commented

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch from d203de1 to c7c315c Compare

February 20, 2025 09:36

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

MOZGIII requested changes

View reviewed changes

Contributor

MOZGIII left a comment

This looks good!

If we add the E2E tests to verify that the solution works overall, and unit tests with mock runtime (as we usually do) to test the niche cases (zero transfer, etc) and for tight regression control - I think we ship it pretty much right away

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-currency-swap/src/lib.rs Outdated Show resolved Hide resolved

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-currency-swap/Cargo.toml Outdated Show resolved Hide resolved

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch from 4c9425c to 01e492c Compare

February 20, 2025 11:57

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-swap/src/lib.rs Outdated Show resolved Hide resolved

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-swap/src/lib.rs Outdated Show resolved Hide resolved

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch from f48f89e to 863a9aa Compare

February 20, 2025 14:14

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-swap/src/lib.rs Outdated Show resolved Hide resolved

Contributor

MOZGIII commented Feb 20, 2025

Thinking about this, we should explicitly test, among other things, that the pot doesn't pay the fee for any tx with this flow.

Contributor Author

dmitrylavrenov commented Feb 20, 2025

Thinking about this, we should explicitly test, among other things, that the pot doesn't pay the fee for any tx with this flow.

Tested manually that pot doesn't pay the fee - confirmed. Additionally will implement some unit tests and add this check to e2e test.

MOZGIII reviewed

View reviewed changes

crates/pallet-native-to-evm-swap/src/lib.rs Outdated Show resolved Hide resolved

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch 9 times, most recently from b0e68a8 to 40e11f7 Compare

February 24, 2025 15:09

MOZGIII reviewed

View reviewed changes

crates/humanode-runtime/src/frontier_precompiles.rs

@@ @@ -76,6 +77,8 @@ pub mod precompiles_constants { @@
                   pub const NATIVE_CURRENCY: u64 = 2050;
                   /// `CurrencySwap` precompile constant.
                   pub const CURRENCY_SWAP: u64 = 2304;

Contributor

MOZGIII Feb 24, 2025

We'll have to eventually deprecate this one; how would we do it?

MOZGIII approved these changes

View reviewed changes

MOZGIII self-requested a review

February 24, 2025 19:43

dmitrylavrenov added 11 commits

February 26, 2025 13:40


          Add swap_fail_no_arguments test for evm to native flow

65b711e


          Add swap_fail_short_argument for evm to native flow

7033fb5


          Add swap_fail_trailing_junk test for evm to native flow


          Some refactoring of evm_to_native tests

4e34927


          Use more elegant way to build precompiles at mock

fd877fd


          Fix typo

192489e


          Add a helper to run succeeded test for native to evm flow

4d7b81d


          Add swap_works_kill_origin for native to evm flow

239520b


          Add swap_keep_alive_works test

b7598fc


          Add some swap failed tests

7269fd0


          Add swap_keep_alive_fails test

167c899

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch 2 times, most recently from f9ed013 to 2046f42 Compare

February 26, 2025 11:12

This was referenced Feb 26, 2025

[backport] Add CallOrCreateInfo to ValidatedTransaction apply result. (#1099) humanode-network/frontier#158

Open

Switch from fungible::Mutate to fungible::Balanced at pallet-evm-swap #1462

Open

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch 2 times, most recently from f9ed013 to 36923d3 Compare

February 27, 2025 07:47


          Switch to mutate fungible interface

dc0ce50

dmitrylavrenov force-pushed the pallet-visible-currency-swap branch from 36923d3 to dc0ce50 Compare

February 27, 2025 08:18

dmitrylavrenov added 11 commits

February 27, 2025 11:23


          Some renaming

5d65269


          Add mode details into process_dispatch_error

9bb2944


          Redesign evm to native tests

8d8710f


          Add swap_fail_target_balance_overflow test

015e5c8


          Redesign run_succeeded_test_and_assert for native to evm tests

3738c36


          Prevent bridge account killing at precompile logic

25e7e19


          Prevent killing bridge pot evm account at evm to native flow

1e057b2


          Add swap_fail_bridge_evm_overflow test

ffa48c6


          Add swap_fail_bridge_native_killed test


          Improve process_dispatch_error handler

4b67c13


          --wip-- [skip ci]

f93a377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet