Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: investigate cost of cloning lattices in state() operator #1669

Open
2 tasks
Tracked by #1683
MingweiSamuel opened this issue Jan 23, 2025 · 0 comments
Open
2 tasks
Tracked by #1683

perf: investigate cost of cloning lattices in state() operator #1669

MingweiSamuel opened this issue Jan 23, 2025 · 0 comments
Labels
dfir_rs runtime (core api) dfir_rs runtime (not the surface syntax) performance

Comments

@MingweiSamuel
Copy link
Member

MingweiSamuel commented Jan 23, 2025 •
edited
Loading

  • do we avoid the clone if we don't use the streaming output?
  • can we improve performance by merging via & or ToOwned instead of just cloning (e.g. iterate by reference to avoid an extra allocation from clone)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dfir_rs runtime (core api) dfir_rs runtime (not the surface syntax) performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MingweiSamuel