Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple actions on the same shortcut #375

Open
ghost opened this issue Jul 11, 2020 · 11 comments
Open

Multiple actions on the same shortcut #375

ghost opened this issue Jul 11, 2020 · 11 comments
Labels
feature-request system:keybinds Keybinds, shortcuts, and general keyboard navigation system:user-interface Looks and actions of the user interface

Comments

@ghost
Copy link

ghost commented Jul 11, 2020

Currently, when assigning an action to a button, only one can be mapped. If one tries to bypass this limit by adding yet another shortcut to the same button with a different action, Hydrus spergs out and removes the newly added shortcut.

For example, since Duplicate Filter is a quality check (for my workflow at least), I want to add "archive file" to the action of "left click" and "right click", in order to archive those files which are not being deleted (that's mapped to another shortcut).

Would be great if this was possible, since it would also save time in Archive/Delete filter (same issue).

@ghost ghost added the feature-request label Jul 11, 2020
@thatfuckingbird
Copy link
Collaborator

For keyboard shortcuts implemented with QShortcut, this can be done with https://doc.qt.io/qt-5/qshortcut.html#activatedAmbiguously

@Mengmoshu
Copy link
Collaborator

Maybe we want a multi action shortcut feature for this, instead of asking the client to blindly accept overlapping shortcuts. Though either way I think Hydrus should be informing users that they've tried to use a key that is already mapped, and what that other mapping is.

My reasoning is that intentionally doing two or more things with one key should be supported. But it would be beneficial to make it a little harder for users to unintentionally map two actions to a key.

@ghost
Copy link
Author

ghost commented Jul 12, 2020

Could always lock it behind advanced mode.

@imtbl imtbl added the system:user-interface Looks and actions of the user interface label Jul 12, 2020
@Mengmoshu
Copy link
Collaborator

What would that even mean? With advanced mode off it just does what it does now?

@ghost
Copy link
Author

ghost commented Jul 12, 2020

You're the one scared of scenarios in which the user doesn't think about his shortcuts for longer than two seconds.

So yes, if you activate advanced mode, you have the new multikey/multishortcut feature and it's all on you. If you don't, you have the current system.

@Mengmoshu
Copy link
Collaborator

Just to clarify, you're suggesting that Advanced Mode silently allow two shortcuts with the same keypress. Which sounds like a fairly workable minimum effort feature. I don't have a problem with that.

I'd still like a version that is more explicitly support for multiple actions on a single shortcut, and which has clear enough UI that Normal Mode users can also be expected to use it.

On a side note, this isn't the Discord, and personal attacks like "you're the one scared of" don't fit the expected tone very well.

@Mengmoshu Mengmoshu reopened this Jul 13, 2020
@ghost
Copy link
Author

ghost commented Jul 13, 2020

I mean, you're the one who's bringing in hypothetical cases based on previous experiences with users that did not read the docs or just don't read anything they do.

I do not mind the feature being behind advanced mode or not. I just want to be able to use two actions with the same keypress.

@Chad90b
Copy link

Chad90b commented Dec 15, 2020

i too would like this feature if for no other reason to do my own sort of filtering. example: one key to both add a tag and then go to the next image. sort of how the duplicate processing already lets you do an action and then it goes to the next image

@Zweibach
Copy link
Collaborator

i too would like this feature if for no other reason to do my own sort of filtering.

Cough #262 cough
Both features would be desired but for the purpose of filtering I'd prefer an extension of the existing filter system to let us do more stuff with it.

@LustWolf
Copy link

Maybe we want a multi action shortcut feature for this, instead of asking the client to blindly accept overlapping shortcuts. Though either way I think Hydrus should be informing users that they've tried to use a key that is already mapped, and what that other mapping is.

My reasoning is that intentionally doing two or more things with one key should be supported. But it would be beneficial to make it a little harder for users to unintentionally map two actions to a key.

@Mengmoshu That would be wonderful.
Particularly chaining multiple commands in a specific order off one shortcut.

@Zweibach Zweibach added the system:keybinds Keybinds, shortcuts, and general keyboard navigation label Nov 20, 2021
@Zweibach
Copy link
Collaborator

For example, since Duplicate Filter is a quality check (for my workflow at least), I want to add "archive file" to the action of "left click" and "right click", in order to archive those files which are not being deleted (that's mapped to another shortcut).

#472 is another option to this part. Otherwise very much yes to the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request system:keybinds Keybinds, shortcuts, and general keyboard navigation system:user-interface Looks and actions of the user interface
Projects
None yet
Development

No branches or pull requests

6 participants