Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fabric): refactor jest test negative test cases #3472

Open
ashnashahgrover opened this issue Aug 11, 2024 · 0 comments · May be fixed by #3735
Open

test(fabric): refactor jest test negative test cases #3472

ashnashahgrover opened this issue Aug 11, 2024 · 0 comments · May be fixed by #3735
Assignees
@adrianbatuto
Labels
enhancement New feature or request

Comments

@ashnashahgrover
Copy link
Contributor

Refactor all the negative test case exception assertions for cactus-plugin-ledger-connector-fabric so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API.

The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: #3455

Acceptance Criteria
Test passes the same as before
Negative test case assertions have been migrated the way it is explained in the parent issue.
@ashnashahgrover ashnashahgrover added the enhancement New feature or request label Aug 11, 2024
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Feb 3, 2025
@adrianbatuto
test(fabric): refactor jest test negative test cases
8147a47 
Primary Changes
----------------
1. Refactored negative test cases in:
   -fabric-watch-blocks-v1-endpoint.test.ts
   -fabric-watch-blocks-delegated-sign-v1-endpoint.test.ts
   -identity-client.test.ts

Fixes hyperledger-cacti#3472

Signed-off-by: adrianbatuto <[email protected]>
@adrianbatuto adrianbatuto linked a pull request Feb 3, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianbatuto adrianbatuto

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(fabric): refactor jest test negative test cases adrianbatuto/cacti
2 participants
@ashnashahgrover @adrianbatuto