-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile time checking for architecture dependent types on serialized structures #2004
Labels
Enhancement
New feature or request
good first issue
Good for newcomers
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
We should also add a runtime test which would traverse the schema map and make sure that no pointer sized type is encountered. This is necessary to guard against faulty manual implementations. Compile test can be added to make sure that there is no pointer sized types in derived implementation |
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 2, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 2, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 5, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 5, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 6, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
that referenced
this issue
May 6, 2022
Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
May 13, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
New feature or request
good first issue
Good for newcomers
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
It would be useful to have compile time checks that ensure our serialized and deserialized types are identical across architectures so that we don't reintroduce fields containing eg usize/isize in future.
The text was updated successfully, but these errors were encountered: