Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the view change method #2133

Closed
s8sato opened this issue Apr 21, 2022 · 1 comment
Closed

Revise the view change method #2133

s8sato opened this issue Apr 21, 2022 · 1 comment
Assignees
@SamHSmith
Labels
Consensus This issue is related to the Sumeragi consensus iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should

Comments

@s8sato
Copy link
Contributor

s8sato commented Apr 21, 2022

Besides shift & shuffle? See discussion
@s8sato s8sato added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 21, 2022
@s8sato s8sato changed the title Revise the validator election method Revise the view change method Apr 21, 2022
@s8sato s8sato mentioned this issue Apr 21, 2022
Merged
2 tasks
@s8sato
Copy link
Contributor Author

s8sato commented Apr 22, 2022 •
edited
Loading

I'd suggest:

  • Shuffle on the nth view change, where n % 3 == 0
  • Shift by f, otherwise

The idea is to maximize the difference of the set of peers.

This change

  • affects how BlockSynchronizer reproduces topologies EDIT: the impact stays within network_topology::Builder::build
  • might be just a makeshift until the emergence of Hijiri Reputation System #1211

@appetrosyan appetrosyan added Bug Something isn't working Optimization Something isn't working as well as it should labels Jun 6, 2022
@appetrosyan appetrosyan removed the Bug Something isn't working label Jul 6, 2022
@SamHSmith SamHSmith added the Blue label Jul 28, 2022
@appetrosyan appetrosyan removed the Blue label Sep 12, 2022
@SamHSmith SamHSmith added the Consensus This issue is related to the Sumeragi consensus label Feb 22, 2023
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Feb 22, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
08f16b0 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Feb 22, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
84ac5d8 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Feb 22, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
60f2c78 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Feb 23, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
320a2c9 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 6, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
85f6fbd 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 6, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
8a652e3 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 6, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
4449c37 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 6, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
a38a85d 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 6, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
8d91fd1 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 8, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
075f418 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 8, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
9e60a12 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 9, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
0e3b14f 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 9, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
7f90b83 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 9, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
7b9d598 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 9, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
21244c4 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Mar 9, 2023
@SamHSmith
[fix] hyperledger-iroha#2133: Rewrite topology to be closer the white…
b563ae1 
…paper.

Signed-off-by: Sam H. Smith <[email protected]>
appetrosyan pushed a commit that referenced this issue Mar 9, 2023
@SamHSmith @appetrosyan
[fix] #2133: Rewrite topology to be closer the whitepaper.
0aca608 
Signed-off-by: Sam H. Smith <[email protected]>
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@SamHSmith @appetrosyan
[fix] #2133: Rewrite topology to be closer the whitepaper.
2de23dc 
Signed-off-by: Sam H. Smith <[email protected]>
mversic pushed a commit that referenced this issue Oct 17, 2023
@SamHSmith @mversic
[fix] #2133: Rewrite topology to be closer the whitepaper.
85befc7 
Signed-off-by: Sam H. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamHSmith SamHSmith

Labels
Consensus This issue is related to the Sumeragi consensus iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SamHSmith @appetrosyan @s8sato