-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ffi_export
on freestanding functions
#2490
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
Should it support functions with return types either then |
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 25, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 25, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
Yes, the type returned is |
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 26, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…anding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…anding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…anding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
…anding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 27, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
…anding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
…freestanding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
…anding functions Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
to ales-tsurko/iroha
that referenced
this issue
Jul 28, 2022
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko
added a commit
that referenced
this issue
Jul 28, 2022
* [feature] #2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] #2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] #2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 6, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 6, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 6, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 7, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 8, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
currently
ffi_export
supports only inherent impl blocks. Expanding the support to include freestanding functions should be very easy.This function:
should produce, once macro is expanded, something like the following
extern fn
declaration:The text was updated successfully, but these errors were encountered: