Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no_validation feature flag on client side of FFI #2799

Open
mversic opened this issue Sep 28, 2022 · 0 comments
Open

no_validation feature flag on client side of FFI #2799

mversic opened this issue Sep 28, 2022 · 0 comments
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Sep 28, 2022

Consider introducing no_validation client flag. Check this discussion

The assumption here is that Iroha can be trusted to be without bugs and will always send valid values. Given this assumption smart contract can shave of a few bytes by not including code for "unnecessary" validity checks

IMO this feature, if introduced, should be enabled by default and only conditionally disabled
@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 28, 2022
@mversic mversic mentioned this issue Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mversic