Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow mutable shared references of non robust types in FFI #2800

Closed
mversic opened this issue Sep 28, 2022 · 0 comments
Closed

Disallow mutable shared references of non robust types in FFI #2800

mversic opened this issue Sep 28, 2022 · 0 comments
Assignees
@mversic
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Security This issue asks for improved security

Comments

@mversic
Copy link
Contributor

mversic commented Sep 28, 2022

At the moment mutable shared references of any Transmute type are allowed in FFI. This is a potential for UB if the receiver side of the FFI mutates the reference in such a way that it's set to a trap value. This should be disabled by default and only conditionally enabled via a new feature flag non_robust_ref_mut

Check code before this comment.
@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 28, 2022
@mversic mversic self-assigned this Sep 28, 2022
@mversic mversic mentioned this issue Sep 28, 2022
Merged
@mversic mversic added the Security This issue asks for improved security label Sep 29, 2022
This was referenced Oct 6, 2022
Closed
Merged
@mversic mversic closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Security This issue asks for improved security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mversic