[fix] #1917: Added easy_from_str_impl macro for use with AssetValueType #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamHSmith
requested review from
s8sato,
appetrosyan,
mversic and
Arjentix
as code owners
github-actions
bot
added
the
iroha2-dev
appetrosyan
previously approved these changes
Apr 4, 2022
SamHSmith
force-pushed
the
decl_macro_asset_value_type2
branch
2 times, most recently
from
84ea691 to
1fdbff9
Compare
mversic
reviewed
Apr 4, 2022
mversic
reviewed
Apr 4, 2022
appetrosyan
reviewed
Apr 4, 2022
SamHSmith
force-pushed
the
decl_macro_asset_value_type2
branch
from
1fdbff9 to
aeecc31
Compare
Arjentix
suggested changes
Apr 4, 2022
…with AssetValueType Signed-off-by: Sam H. Smith <[email protected]>
Signed-off-by: Sam H. Smith <[email protected]>
SamHSmith
force-pushed
the
decl_macro_asset_value_type2
branch
from
aeecc31 to
75961f7
Compare
appetrosyan
approved these changes
Apr 5, 2022
Arjentix
approved these changes
Apr 5, 2022
| } | ||
|
|
||
| easy_from_str_impl! {AssetValueType, Quantity, BigQuantity, Fixed, Store} |
There was a problem hiding this comment.
Just to mention for future macros. I think that's not a good tradition in Iroha to write such simple to implement but hard to read syntax.
Take a look at this rule:
Rust macros let you dream up practically whatever input syntax you want. Aim to keep input syntax familiar and cohesive with the rest of your users' code by mirroring existing Rust syntax where possible. Pay attention to the choice and placement of keywords and punctuation.
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Created a variadic declarative macro that implements FromStr for C like enums.
Issue
#1917
Benefits
Future FromStr implementations for C like enums can be a lot smaller codesize.
Possible Drawbacks
May be harder to read and understand for some.